Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: tools/android/loading/request_dependencies_lens_unittest.py

Issue 1633813005: tools/android/loading: Add support for multiple redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/request_dependencies_lens_unittest.py
diff --git a/tools/android/loading/request_dependencies_lens_unittest.py b/tools/android/loading/request_dependencies_lens_unittest.py
index 9549d042bd28b01a3e5d4b113696faf41f944b35..5c02576c6c0eb1235ab018e23f6e636d0f336703 100644
--- a/tools/android/loading/request_dependencies_lens_unittest.py
+++ b/tools/android/loading/request_dependencies_lens_unittest.py
@@ -37,9 +37,17 @@ class FakeRequestTrack(devtools_monitor.Track):
class RequestDependencyLensTestCase(unittest.TestCase):
_REDIRECT_REQUEST = Request.FromJsonDict(
- {'url': 'http://bla.com', 'request_id': '1234.1.redirect',
+ {'url': 'http://bla.com', 'request_id': '1234.redirect.1',
'initiator': {'type': 'other'},
'timestamp': 1, 'timing': TimingFromDict({})})
+ _REDIRECTED_REQUEST = Request.FromJsonDict({
+ 'url': 'http://bla.com',
+ 'request_id': '1234.1',
+ 'frame_id': '123.1',
+ 'initiator': {'type': 'redirect',
+ 'initiating_request': '1234.redirect.1'},
+ 'timestamp': 2,
+ 'timing': TimingFromDict({})})
_REQUEST = Request.FromJsonDict({'url': 'http://bla.com',
'request_id': '1234.1',
'frame_id': '123.1',
@@ -79,7 +87,8 @@ class RequestDependencyLensTestCase(unittest.TestCase):
'frame_id': '123.13', 'parent_frame_id': '123.1'}])
def testRedirectDependency(self):
- request_track = FakeRequestTrack([self._REDIRECT_REQUEST, self._REQUEST])
+ request_track = FakeRequestTrack([
+ self._REDIRECT_REQUEST, self._REDIRECTED_REQUEST])
loading_trace = LoadingTrace(None, None, PageTrack(None),
request_track, None)
request_dependencies_lens = RequestDependencyLens(loading_trace)
@@ -114,7 +123,7 @@ class RequestDependencyLensTestCase(unittest.TestCase):
def testSeveralDependencies(self):
request_track = FakeRequestTrack(
- [self._REDIRECT_REQUEST, self._REQUEST, self._JS_REQUEST,
+ [self._REDIRECT_REQUEST, self._REDIRECTED_REQUEST, self._JS_REQUEST,
self._JS_REQUEST_2])
loading_trace = LoadingTrace(None, None, PageTrack(None),
request_track, None)

Powered by Google App Engine
This is Rietveld 408576698