Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 16338006: Roll valgrind-variant r145 for OS X 10.6 (Closed)

Created:
7 years, 6 months ago by Alexander Potapenko
Modified:
7 years, 6 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Visibility:
Public.

Description

Roll valgrind-variant r145 for OS X 10.6 The new version contains a Darwin-specific fix for the address space manager that prevents the memory advisor from suggesting incorrect mmap() arguments. BUG=245745 TBR=timurrrr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac_10.6/bin/valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind-listener View Binary file 0 comments Download
M binaries/mac_10.6/bin/vgdb View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M scripts/build-memcheck-for-chromium.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
TBR
7 years, 6 months ago (2013-06-05 08:25:57 UTC) #1
Alexander Potapenko
Committed patchset #1 manually as r204209 (presubmit successful).
7 years, 6 months ago (2013-06-05 08:29:36 UTC) #2
Timur Iskhodzhanov
7 years, 6 months ago (2013-06-05 08:37:28 UTC) #3
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698