Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 16338005: drive: Remove FakeCacheMetadata (Closed)

Created:
7 years, 6 months ago by hashimoto
Modified:
7 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Remove FakeCacheMetadata FakeCacheMetadata has been maintained to avoid slowness in tests (http://crbug.com/137945). But we are going to merge cache DB with metadata DB and there will be no cache DB initialization at all. (i.e. 0 second spent for cache DB initialization in future) We no longer need to maintain this level of abstraction. BUG=234487 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203878

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -298 lines) Patch
M chrome/browser/chromeos/drive/file_cache.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 2 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_metadata.h View 1 3 chunks +20 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_metadata.cc View 11 chunks +30 lines, -211 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_metadata_unittest.cc View 4 chunks +6 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
7 years, 6 months ago (2013-06-04 04:09:54 UTC) #1
kinaba
lgtm https://codereview.chromium.org/16338005/diff/2001/chrome/browser/chromeos/drive/file_cache_metadata.h File chrome/browser/chromeos/drive/file_cache_metadata.h (right): https://codereview.chromium.org/16338005/diff/2001/chrome/browser/chromeos/drive/file_cache_metadata.h#newcode43 chrome/browser/chromeos/drive/file_cache_metadata.h:43: explicit FileCacheMetadata(base::SequencedTaskRunner* blocking_task_runner); Could you add a comment ...
7 years, 6 months ago (2013-06-04 06:24:46 UTC) #2
hashimoto
https://codereview.chromium.org/16338005/diff/2001/chrome/browser/chromeos/drive/file_cache_metadata.h File chrome/browser/chromeos/drive/file_cache_metadata.h (right): https://codereview.chromium.org/16338005/diff/2001/chrome/browser/chromeos/drive/file_cache_metadata.h#newcode43 chrome/browser/chromeos/drive/file_cache_metadata.h:43: explicit FileCacheMetadata(base::SequencedTaskRunner* blocking_task_runner); On 2013/06/04 06:24:46, kinaba wrote: > ...
7 years, 6 months ago (2013-06-04 06:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/16338005/6002
7 years, 6 months ago (2013-06-04 06:30:49 UTC) #4
hashimoto
7 years, 6 months ago (2013-06-04 06:55:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r203878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698