Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1633793003: [MD] fix bookmark bar/URL bar drag image color for OTR mode. (Closed)

Created:
4 years, 11 months ago by Evan Stade
Modified:
4 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] fix bookmark bar/URL bar drag image color for OTR mode. Do this by using textfield colors instead of label default colors. The change to pre-MD and non-OTR should be extremely minimal (text that's \#222 becomes \#000). The same colors are used regardless of the drag source (bookmark bar or location bar), and this just matches the location bar instead of the bookmark bar. Either way it's hard to notice a difference anywhere except MD OTR mode. Also support systems without translucency better. We don't need a text shadow but we do need a background (and border) on these systems. BUG=581239 Committed: https://crrev.com/9125a821cd8353d85b026702fc218167ac96f7a0 Cr-Commit-Position: refs/heads/master@{#371544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M ui/views/button_drag_utils.cc View 2 chunks +14 lines, -7 lines 0 comments Download
M ui/views/drag_utils.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
4 years, 11 months ago (2016-01-26 01:42:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633793003/1
4 years, 11 months ago (2016-01-26 01:44:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 02:54:54 UTC) #6
sadrul
lgtm
4 years, 11 months ago (2016-01-26 17:58:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633793003/1
4 years, 11 months ago (2016-01-26 18:19:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 18:25:44 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 18:26:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9125a821cd8353d85b026702fc218167ac96f7a0
Cr-Commit-Position: refs/heads/master@{#371544}

Powered by Google App Engine
This is Rietveld 408576698