Add UseCounters for some nonstandard JavaScript features

Add UseCounters for some nonstandard JavaScript features

This patch adds a UseCounter for each of the following:
- Allowing duplicate sloppy-mode block-scoped function declarations
  in the exact same scope
- for-in loops with an initializer

The patch also refactors some of the declaration code to clean it up and
enable the first counter, and adds additional unit tests to nail down
the semantics of edge cases of sloppy-mode block-scoped function declarations.

BUG=v8:4693, chromium:579395
LOG=N
R=adamk

Committed: https://crrev.com/11e8c03f94c6110d9bc7397741a6904580fac86b
Cr-Commit-Position: refs/heads/master@{#33650}

[Dan Ehrenberg, 2016-01-25 21:03:37]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 21:03:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633743003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633743003/1

[commit-bot: I haz the power, 2016-01-25 21:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 21:20:23]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/1898)
  v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Dan Ehrenberg, 2016-01-26 05:40:14]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 05:40:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633743003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633743003/20001

[commit-bot: I haz the power, 2016-01-26 06:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 06:05:46]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-01-29 23:52:57]

PTAL

[adamk, 2016-02-01 18:26:58]

lgtm % comment formatting

https://codereview.chromium.org/1633743003/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1633743003/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1988: // is
Please re-flow this whole comment  to avoid lines like this one.

[Dan Ehrenberg, 2016-02-01 22:02:36]

https://codereview.chromium.org/1633743003/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1633743003/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1988: // is
On 2016/02/01 at 18:26:58, adamk wrote:
> Please re-flow this whole comment  to avoid lines like this one.

Done

https://codereview.chromium.org/1633743003/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1988: // is
On 2016/02/01 at 18:26:58, adamk wrote:
> Please re-flow this whole comment  to avoid lines like this one.

Done

[Dan Ehrenberg, 2016-02-01 22:02:38]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-02-01 22:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1633743003/#ps40001
(title: "Rebase and reflow comment")

[commit-bot: I haz the power, 2016-02-01 22:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633743003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633743003/40001

[commit-bot: I haz the power, 2016-02-01 23:01:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-01 23:02:14]

Description was changed from

==========
Add UseCounters for some nonstandard JavaScript features

This patch adds a UseCounter for each of the following:
- Allowing duplicate sloppy-mode block-scoped function declarations
  in the exact same scope
- for-in loops with an initializer

The patch also refactors some of the declaration code to clean it up and
enable the first counter, and adds additional unit tests to nail down
the semantics of edge cases of sloppy-mode block-scoped function declarations.

BUG=v8:4693,chromium:579395
LOG=N
R=adamk
==========

to

==========
Add UseCounters for some nonstandard JavaScript features

This patch adds a UseCounter for each of the following:
- Allowing duplicate sloppy-mode block-scoped function declarations
  in the exact same scope
- for-in loops with an initializer

The patch also refactors some of the declaration code to clean it up and
enable the first counter, and adds additional unit tests to nail down
the semantics of edge cases of sloppy-mode block-scoped function declarations.

BUG=v8:4693,chromium:579395
LOG=N
R=adamk

Committed: https://crrev.com/11e8c03f94c6110d9bc7397741a6904580fac86b
Cr-Commit-Position: refs/heads/master@{#33650}
==========

[commit-bot: I haz the power, 2016-02-01 23:02:15]

Patchset 3 (id:??) landed as
https://crrev.com/11e8c03f94c6110d9bc7397741a6904580fac86b
Cr-Commit-Position: refs/heads/master@{#33650}