Native SSID extraction moved to platform code on Android

net/base/network_quality_estimator.cc

Index: net/base/network_quality_estimator.cc
diff --git a/net/base/network_quality_estimator.cc b/net/base/network_quality_estimator.cc
index c67b641101ae0a44f989c5b65b2542502ec8796c..9878f2f3d6a5e3af544557cfc07c91d603d0d6d4 100644
--- a/net/base/network_quality_estimator.cc
+++ b/net/base/network_quality_estimator.cc
@@ -776,9 +776,10 @@ NetworkQualityEstimator::GetCurrentNetworkID() const {
       case NetworkChangeNotifier::ConnectionType::CONNECTION_ETHERNET:
         break;
       case NetworkChangeNotifier::ConnectionType::CONNECTION_WIFI:
-#if defined(OS_ANDROID) || defined(OS_LINUX) || defined(OS_CHROMEOS) || \
-    defined(OS_WIN)
+#if defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_WIN)
         network_id.id = GetWifiSSID();
+#elif defined(OS_ANDROID)
+        network_id.id = android::GetCurrentWifiConnectionSsid();

[Ryan Sleevi, 2016/01/26 20:22:26]

DESIGN: Given that network_interfaces is already designed in a
platform-abstracted way to avoid these #ifdefs, I would instead recommend the
following approach:

In network_interfaces_linux.cc, guard GetWifiSSID by a

#if !defined(OS_ANDROID)
std::string GetWifiSSID() {
  ...
}
#endif

Then, implement a network_interfaces_android.cc which implements the GetWifiSSID
function, and either calls android::GetCurrentWifiConnectionSsid() or simply
move that implementation logic (the JNI call) into the _android file.

Add the _android file to the .gyp and .gn files, conditionally as appropriate.

This ensures the API semantics of net::GetWifiSSID() remain the same, and also
avoids the inconsistent naming being introduced here (SSID vs Ssid)

[Ryan Hamilton, 2016/01/26 20:24:48]

Oo! Good idea.

[ripp, 2016/01/27 12:09:06]

Done.

[ripp, 2016/01/27 12:09:06]

Done.

 #endif
         break;
       case NetworkChangeNotifier::ConnectionType::CONNECTION_2G: