chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 16337017: Remove blank URL when starting sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 16337017: Remove blank URL when starting sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index 580749f0ce7b258e9a64e199996e303737b3007a..e63e1d6f5b59b084b44de9c6ef65d867a84b24ff 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -1206,6 +1206,7 @@ void OneClickSigninHelper::DidStopLoading(

contents,

start_mode));

} else {

+ RemoveCurrentHistoryItem(contents);

Roger Tawa OOO till Jul 10th 2013/06/03 21:15:24 Maybe this should be done at line 1189 above, and

StartSync(

StartSyncArgs(profile, browser, auto_accept_, session_index_,

email_, password_, force_same_tab_navigation,

« no previous file with comments | « no previous file | no next file » | no next file with comments »