Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 16337017: Remove blank URL when starting sync (Closed)

Created:
7 years, 6 months ago by bcwhite
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Remove blank URL when starting sync BUG=245607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204363

Patch Set 1 #

Total comments: 1

Patch Set 2 : always remove continue URL from history #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bcwhite
I think this is all that is necessary. The "blank" page no longer appears in ...
7 years, 6 months ago (2013-06-03 20:18:45 UTC) #1
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/16337017/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/16337017/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode1209 chrome/browser/ui/sync/one_click_signin_helper.cc:1209: RemoveCurrentHistoryItem(contents); Maybe this should be done at line 1189 ...
7 years, 6 months ago (2013-06-03 21:15:24 UTC) #2
bcwhite
New CL just always removes the "continue" URL from the history which allows all other ...
7 years, 6 months ago (2013-06-04 12:46:43 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm As for whether we need to remove it from the error case above, I ...
7 years, 6 months ago (2013-06-05 16:55:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/16337017/7001
7 years, 6 months ago (2013-06-05 17:06:04 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 23:48:18 UTC) #6
Message was sent while issue was closed.
Change committed as 204363

Powered by Google App Engine
This is Rietveld 408576698