Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1633683002:
Drop contradictory condition in min-width clamping (Closed)
|
Created:
4 years, 10 months ago by davve Modified:
4 years, 10 months ago Reviewers:
mstensho (USE GERRIT) CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDrop contradictory condition in min-width clamping
isMaxSizeNone() is nonsensical for min-width. Zero (but represented as
Auto) is initial Length value for min-width, not MaxSizeNone. This
stands out after the rename from isUndefined() to isMaxSizeNone(). But
in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was
a just long alias for |false| so remove it.
Committed: https://crrev.com/99a0ad7eeaa0d05f7e7973f74536a5a9cdf9a730
Cr-Commit-Position: refs/heads/master@{#371494}
Patch Set 1 #Patch Set 2 : min-width:0 (represented as auto) has special code; hit it. #Messages
Total messages: 19 (10 generated)
The CQ bit was checked by davve@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633683002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by davve@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633683002/20001
Description was changed from ========== Adjust min-width computation for replaced content isMaxSizeNone() is nonsensical for min-width. Auto is initial Length value for min-width. This looks even more odd now, after the rename from isUndefined() to isMaxSizeNone(). BUG= ========== to ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Auto is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
davve@opera.com changed reviewers: + mstensho@opera.com
PTAL.
lgtm
Description was changed from ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Auto is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. ========== to ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Zero (but represented as Auto) is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. ==========
The CQ bit was checked by davve@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633683002/20001
Message was sent while issue was closed.
Description was changed from ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Zero (but represented as Auto) is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. ========== to ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Zero (but represented as Auto) is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Zero (but represented as Auto) is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. ========== to ========== Drop contradictory condition in min-width clamping isMaxSizeNone() is nonsensical for min-width. Zero (but represented as Auto) is initial Length value for min-width, not MaxSizeNone. This stands out after the rename from isUndefined() to isMaxSizeNone(). But in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was a just long alias for |false| so remove it. Committed: https://crrev.com/99a0ad7eeaa0d05f7e7973f74536a5a9cdf9a730 Cr-Commit-Position: refs/heads/master@{#371494} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/99a0ad7eeaa0d05f7e7973f74536a5a9cdf9a730 Cr-Commit-Position: refs/heads/master@{#371494} |
