[Interpreter] Fix deopting from inline functions.

[Interpreter] Fix deopting from inline functions.

Rename IntepreterExceptionEntryHandler builtin to InterpreterEnterBytecodeDispatch
and use it as the return address when building interpreter frames during deopt.
This ensures that we restart execution of the outer frame at the correct
bytecode.

BUG=v8:4280, v8:4678
LOG=N

Committed: https://crrev.com/32eade634f3007d6263f0d2fe9250915e5158029
Cr-Commit-Position: refs/heads/master@{#33512}

[rmcilroy, 2016-01-25 15:53:45]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 15:53:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633633002/1

[rmcilroy, 2016-01-25 15:54:00]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-01-25 15:54:00]

Michi, PTAL, thanks.

[commit-bot: I haz the power, 2016-01-25 15:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 15:54:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/463)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/460)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10110)

[MTBrandyberry, 2016-01-25 16:24:37]

On 2016/01/25 15:54:54, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
>   v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/463)
>   v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/460)
>   v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
>   v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10110)

Can ppc be included for trivial changes like this?

[rmcilroy, 2016-01-25 17:26:20]

> Can ppc be included for trivial changes like this?

Sorry, I meant to include all archs but missed ppc. Added.

[rmcilroy, 2016-01-25 17:26:24]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 17:26:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633633002/20001

[commit-bot: I haz the power, 2016-01-25 17:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 17:58:12]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-01-26 10:25:13]

LGTM. Just one nit to address.

https://codereview.chromium.org/1633633002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1633633002/diff/20001/src/objects.h#newcode4949
src/objects.h:4949: inline bool is_interpreter_entry_trampoline();
nit: The interpreter predicates (i.e. the ones using code-object identity to
determine the result) are somewhat hiding in between the IC-related predicates
(i.e. the ones that use the kind field). Can we visually separate out the two
interpreter related predicates into a separate block (i.e. move them down 5
lines and add a one lines comment)?

[rmcilroy, 2016-01-26 11:32:24]

https://codereview.chromium.org/1633633002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1633633002/diff/20001/src/objects.h#newcode4949
src/objects.h:4949: inline bool is_interpreter_entry_trampoline();
On 2016/01/26 10:25:13, Michael Starzinger wrote:
> nit: The interpreter predicates (i.e. the ones using code-object identity to
> determine the result) are somewhat hiding in between the IC-related predicates
> (i.e. the ones that use the kind field). Can we visually separate out the two
> interpreter related predicates into a separate block (i.e. move them down 5
> lines and add a one lines comment)?

Done.

[rmcilroy, 2016-01-26 11:33:04]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-01-26 11:33:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1633633002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-26 11:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633633002/60001

[commit-bot: I haz the power, 2016-01-26 12:22:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-26 12:23:06]

Description was changed from

==========
[Interpreter] Fix deopting from inline functions.

Rename IntepreterExceptionEntryHandler builtin to
InterpreterEnterBytecodeDispatch
and use it as the return address when building interpreter frames during deopt.
This ensures that we restart execution of the outer frame at the correct
bytecode.

BUG=v8:4280,v8:4678
LOG=N
==========

to

==========
[Interpreter] Fix deopting from inline functions.

Rename IntepreterExceptionEntryHandler builtin to
InterpreterEnterBytecodeDispatch
and use it as the return address when building interpreter frames during deopt.
This ensures that we restart execution of the outer frame at the correct
bytecode.

BUG=v8:4280,v8:4678
LOG=N

Committed: https://crrev.com/32eade634f3007d6263f0d2fe9250915e5158029
Cr-Commit-Position: refs/heads/master@{#33512}
==========

[commit-bot: I haz the power, 2016-01-26 12:23:07]

Patchset 4 (id:??) landed as
https://crrev.com/32eade634f3007d6263f0d2fe9250915e5158029
Cr-Commit-Position: refs/heads/master@{#33512}