Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 163363003: Don't mix handler flags into regular flag compuation. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, tfarina
Visibility:
Public.

Description

Don't mix handler flags into regular flag computation. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19384

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -93 lines) Patch
M src/a64/ic-a64.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/code-stubs.h View 1 4 chunks +3 lines, -9 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/ic.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 3 chunks +9 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 5 chunks +11 lines, -19 lines 0 comments Download
M src/stub-cache.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
M src/type-info.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-13 14:18:13 UTC) #1
tfarina
Fixed small typo in CL: s/compuation/computation
6 years, 10 months ago (2014-02-13 15:23:32 UTC) #2
Igor Sheludko
https://codereview.chromium.org/163363003/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/163363003/diff/1/src/code-stubs.h#newcode950 src/code-stubs.h:950: STATIC_ASSERT(KindBits::kSize == 4); Do we still need this assert ...
6 years, 10 months ago (2014-02-14 14:04:14 UTC) #3
Igor Sheludko
lgtm
6 years, 10 months ago (2014-02-14 14:30:28 UTC) #4
Toon Verwaest
6 years, 10 months ago (2014-02-14 15:15:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19384 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698