Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 16336024: add size limit for using glyphcache. above that, draw using paths (Closed)

Created:
7 years, 6 months ago by reed1
Modified:
7 years, 6 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add size limit for using glyphcache. above that, draw using paths BUG= R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=9429

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -76 lines) Patch
M include/core/SkDraw.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 2 3 4 chunks +57 lines, -2 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 3 4 chunks +64 lines, -7 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 3 10 chunks +97 lines, -63 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
1. not really optimized yet (though I haven't timed it either) 2. still need to ...
7 years, 6 months ago (2013-06-03 21:47:33 UTC) #1
reed1
timed, and at 256, there was only about a 3% slowdown for drawing via paths, ...
7 years, 6 months ago (2013-06-04 13:48:57 UTC) #2
bungeman-skia
Why not? LGTM with hinting flag and comment. https://codereview.chromium.org/16336024/diff/6001/include/core/SkPaint.h File include/core/SkPaint.h (right): https://codereview.chromium.org/16336024/diff/6001/include/core/SkPaint.h#newcode1019 include/core/SkPaint.h:1019: kMaxSizeForGlyphCache ...
7 years, 6 months ago (2013-06-04 14:27:58 UTC) #3
reed1
PTAL https://codereview.chromium.org/16336024/diff/6001/include/core/SkPaint.h File include/core/SkPaint.h (right): https://codereview.chromium.org/16336024/diff/6001/include/core/SkPaint.h#newcode1019 include/core/SkPaint.h:1019: kMaxSizeForGlyphCache = 256, On 2013/06/04 14:27:58, bungeman1 wrote: ...
7 years, 6 months ago (2013-06-04 15:58:22 UTC) #4
bungeman-skia
lgtm
7 years, 6 months ago (2013-06-04 16:05:35 UTC) #5
reed1
7 years, 6 months ago (2013-06-04 16:56:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r9429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698