Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: trunk/Source/core/dom/Text.cpp

Issue 16336010: Revert 150924 "Node::lazyAttach shouldn't lie about being attached" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/dom/Node.cpp ('k') | trunk/Source/core/dom/shadow/ElementShadow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/dom/Text.cpp
===================================================================
--- trunk/Source/core/dom/Text.cpp (revision 151673)
+++ trunk/Source/core/dom/Text.cpp (working copy)
@@ -294,13 +294,10 @@
void Text::updateTextRenderer(unsigned offsetOfReplacedData, unsigned lengthOfReplacedData)
{
- if (!attached() && !needsStyleRecalc())
+ if (!attached())
return;
RenderText* textRenderer = toRenderText(renderer());
if (!textRenderer || !textRendererIsNeeded(NodeRenderingContext(this, textRenderer->style()))) {
- // FIXME: Editing code expects that inserting a text node will produce a renderer
- // immediately so it can inspect the style of the text nodes. We should fix this
- // so we can lazyReattach here.
reattach();
return;
}
« no previous file with comments | « trunk/Source/core/dom/Node.cpp ('k') | trunk/Source/core/dom/shadow/ElementShadow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698