Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: trunk/Source/core/dom/Node.h

Issue 16336010: Revert 150924 "Node::lazyAttach shouldn't lie about being attached" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/dom/Element.cpp ('k') | trunk/Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/dom/Node.h
===================================================================
--- trunk/Source/core/dom/Node.h (revision 151673)
+++ trunk/Source/core/dom/Node.h (working copy)
@@ -392,8 +392,12 @@
bool isV8CollectableDuringMinorGC() const { return getFlag(V8CollectableDuringMinorGCFlag); }
void setV8CollectableDuringMinorGC(bool flag) { setFlag(flag, V8CollectableDuringMinorGCFlag); }
- void lazyAttach();
- void lazyReattach();
+ enum ShouldSetAttached {
+ SetAttached,
+ DoNotSetAttached
+ };
+ void lazyAttach(ShouldSetAttached = SetAttached);
+ void lazyReattach(ShouldSetAttached = SetAttached);
virtual void setFocus(bool flag);
virtual void setActive(bool flag = true, bool pause = false);
@@ -871,11 +875,11 @@
lazyReattach();
}
-inline void Node::lazyReattach()
+inline void Node::lazyReattach(ShouldSetAttached shouldSetAttached)
{
if (attached())
detach();
- lazyAttach();
+ lazyAttach(shouldSetAttached);
}
// Need a template since ElementShadow is not a Node, but has the style recalc methods.
« no previous file with comments | « trunk/Source/core/dom/Element.cpp ('k') | trunk/Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698