EsParserH264 should set proper video profile

EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG= internal b/26217237

Committed: https://crrev.com/ca3179d8789933bc945f9e221bd64ea1a6c6e935
Cr-Commit-Position: refs/heads/master@{#371595}

[erickung1, 2016-01-26 03:40:26]

Description was changed from

==========
EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG=
==========

to

==========
EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG= internal b/26217237
==========

[erickung1, 2016-01-26 03:40:26]

erickung@chromium.org changed reviewers:
+ servolk@chromium.org, xhwang@chromium.org

[xhwang, 2016-01-26 17:18:50]

lgtm % nit

https://codereview.chromium.org/1633573003/diff/1/media/formats/mp2t/es_parse...
File media/formats/mp2t/es_parser_h264.cc (right):

https://codereview.chromium.org/1633573003/diff/1/media/formats/mp2t/es_parse...
media/formats/mp2t/es_parser_h264.cc:48: return VIDEO_CODEC_PROFILE_UNKNOWN;
nit:

Remove the default so that if this list is not exhaustive we'll get a compiler
error.

Then before the return, add something like

NOTREACHED() << "unknown video profile: " << profile_idc;"

[erickung1, 2016-01-26 19:44:34]

https://codereview.chromium.org/1633573003/diff/1/media/formats/mp2t/es_parse...
File media/formats/mp2t/es_parser_h264.cc (right):

https://codereview.chromium.org/1633573003/diff/1/media/formats/mp2t/es_parse...
media/formats/mp2t/es_parser_h264.cc:48: return VIDEO_CODEC_PROFILE_UNKNOWN;
On 2016/01/26 17:18:50, xhwang wrote:
> nit:
> 
> Remove the default so that if this list is not exhaustive we'll get a compiler
> error.
> 
> Then before the return, add something like
> 
> NOTREACHED() << "unknown video profile: " << profile_idc;"

Done.

[erickung1, 2016-01-26 19:44:39]

The CQ bit was checked by erickung@chromium.org

[erickung1, 2016-01-26 19:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1633573003/#ps20001
(title: "Remove Default in Switch case")

[commit-bot: I haz the power, 2016-01-26 19:46:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633573003/20001

[commit-bot: I haz the power, 2016-01-26 21:00:27]

Description was changed from

==========
EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG= internal b/26217237
==========

to

==========
EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG= internal b/26217237
==========

[commit-bot: I haz the power, 2016-01-26 21:00:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 21:01:59]

Description was changed from

==========
EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG= internal b/26217237
==========

to

==========
EsParserH264 should set proper video profile

Sets video profile based on profile idc in SPS header rather
than setting VIDEO_CODEC_PROFILE_UNKNOWN always.

BUG= internal b/26217237

Committed: https://crrev.com/ca3179d8789933bc945f9e221bd64ea1a6c6e935
Cr-Commit-Position: refs/heads/master@{#371595}
==========

[commit-bot: I haz the power, 2016-01-26 21:02:00]

Patchset 2 (id:??) landed as
https://crrev.com/ca3179d8789933bc945f9e221bd64ea1a6c6e935
Cr-Commit-Position: refs/heads/master@{#371595}