Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1633573002: [interpreter] Fix lookup of overlapping handler ranges. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-remove-fallback
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix lookup of overlapping handler ranges. This fixes corner cases where the start offsets of exception handler regions within the handler table fall together. This assumption was based on full-codegen code and no longer holds with the interpreter. The tables however are still well nested and code has been added to verify that in debug mode. R=rmcilroy@chromium.org BUG=v8:4674 LOG=n Committed: https://crrev.com/21b6e077fadc7edb27ee0d947cef4bfd47020cab Cr-Commit-Position: refs/heads/master@{#33495}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M src/objects.cc View 2 chunks +9 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/test262/test262.status View 2 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-25 14:40:22 UTC) #1
rmcilroy
LGTM, thanks.
4 years, 11 months ago (2016-01-25 14:47:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633573002/20001
4 years, 11 months ago (2016-01-25 16:11:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 16:18:16 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 16:19:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21b6e077fadc7edb27ee0d947cef4bfd47020cab
Cr-Commit-Position: refs/heads/master@{#33495}

Powered by Google App Engine
This is Rietveld 408576698