Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

Issue 1633553002: Change in focus with movement of Arrow keys for RTL radio buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp b/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
index eca599df57a6362b148961f68780535b40e66d83..3d4993e90b7b3d1fe1bfd1c0f45ae6d8ec31ea46 100644
--- a/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
@@ -73,6 +73,8 @@ void RadioInputType::handleClickEvent(MouseEvent* event)
HTMLInputElement* RadioInputType::findNextFocusableRadioButtonInGroup(HTMLInputElement* currentElement, bool forward)
{
HTMLElement* htmlElement;
+ if (computedTextDirection() == RTL)
tkent 2016/02/03 23:45:37 Here is not a right place to check RTL. We don't n
chakshu 2016/02/08 09:46:40 Done.
+ forward = !(forward);
for (htmlElement = nextElement(*currentElement, element().form(), forward); htmlElement; htmlElement = nextElement(*htmlElement, element().form(), forward)) {
if (!isHTMLInputElement(*htmlElement))
continue;

Powered by Google App Engine
This is Rietveld 408576698