Issue 16335022: Re-implement PageState serialization without a Blink API dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16335022: Re-implement PageState serialization without a Blink API dependency. (Closed)

Created:
7 years, 6 months ago by darin (slow to review)

Modified:
7 years, 6 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-implement PageState serialization without a Blink API dependency.

Patch Set 1 #

Patch Set 2 : Fix builds; add computing referenced files. #

Patch Set 3 : Stop building glue_serialize_unittest.cc #

Patch Set 4 : Rebase #

Patch Set 5 : Add unit test #

Patch Set 6 : Fix crash. #

Patch Set 7 : Now with backwards compat tests. #

Patch Set 8 : Rebase #

Patch Set 9 : Fix build. #

Patch Set 10 : Update with more output when tests for equality fail #

Patch Set 11 : Rebase #

Patch Set 12 : Simpler impl. #

Patch Set 13 : REbase #

Patch Set 14 : Fix VS10 build #

Patch Set 15 : Improvements. #

Patch Set 16 : Log parse errors. #

Patch Set 17 : Fix Windows build. #

Patch Set 18 : Cleanup #

Patch Set 19 : Cleanups #

Patch Set 20 : With similarity #

Patch Set 21 : base64 encoded data #

Patch Set 22 : Fix tests. #

Patch Set 23 : Fix IOS #

Patch Set 24 : Copy data files for Android #

Patch Set 25 : Rebase #

Patch Set 26 : Add code to generate backwards compat test cases. #

Patch Set 27 : Removed support for older versions. #

Patch Set 28 : #

Patch Set 29 : Fix Windows build #

Patch Set 30 : Disable v11 test on Android. #

Patch Set 31 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1349 lines, -1554 lines)			Patch
M	base/base.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/strings/nullable_string16.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	3 chunks	+15 lines, -1 line	0 comments	Download
A +	base/strings/nullable_string16.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28	1 chunk	+8 lines, -5 lines	0 comments	Download
M	build/android/pylib/gtest/test_runner.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+1 line, -0 lines	0 comments	Download
A	content/common/page_state_serialization.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+80 lines, -0 lines	0 comments	Download
A +	content/common/page_state_serialization.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30	8 chunks	+438 lines, -439 lines	0 comments	Download
A	content/common/page_state_serialization_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	1 chunk	+411 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	2 chunks	+1 line, -1 line	0 comments	Download
M	content/public/common/page_state.cc	View	1 2 3 4	2 chunks	+96 lines, -0 lines	0 comments	Download
D	content/public/common/page_state_ios.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22	1 chunk	+0 lines, -43 lines	0 comments	Download
M	content/public/renderer/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/renderer/history_item_serialization.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30	1 chunk	+210 lines, -6 lines	0 comments	Download
A	content/test/data/page_state/serialized_v11.dat	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+21 lines, -0 lines	0 comments	Download
A	content/test/data/page_state/serialized_v12.dat	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+21 lines, -0 lines	0 comments	Download
A	content/test/data/page_state/serialized_v13.dat	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+21 lines, -0 lines	0 comments	Download
A	content/test/data/page_state/serialized_v14.dat	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+20 lines, -0 lines	0 comments	Download
D	webkit/glue/glue_serialize_deprecated.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30	1 chunk	+0 lines, -57 lines	0 comments	Download
D	webkit/glue/glue_serialize_deprecated.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30	1 chunk	+0 lines, -670 lines	0 comments	Download
D	webkit/glue/glue_serialize_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	1 chunk	+0 lines, -328 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

base64 encoded data

Expand Messages | Collapse Messages