Add NaCl proxies for Pepper Video Source and Destination resources.

ppapi/proxy/video_source_resource.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/video_source_resource.h"
 
 #include "base/bind.h"
 #include "ipc/ipc_message.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/private/pp_video_frame_private.h"
@@ skipping 48 matching lines @@
 int32_t VideoSourceResource::GetFrame(
     PP_VideoFrame_Private* frame,
     scoped_refptr<TrackedCallback> callback) {
   if (!is_open_)
     return PP_ERROR_FAILED;
 
   if (TrackedCallback::IsPending(get_frame_callback_))
     return PP_ERROR_INPROGRESS;
 
   get_frame_callback_ = callback;
-
   Call<PpapiPluginMsg_VideoSource_GetFrameReply>(RENDERER,
       PpapiHostMsg_VideoSource_GetFrame(),
       base::Bind(&VideoSourceResource::OnPluginMsgGetFrameComplete, this,
                  frame));
   return PP_OK_COMPLETIONPENDING;
 }
 
 void VideoSourceResource::Close() {
   Post(RENDERER, PpapiHostMsg_VideoSource_Close());
 
   if (TrackedCallback::IsPending(open_callback_))
     open_callback_->PostAbort();
   if (TrackedCallback::IsPending(get_frame_callback_))
     get_frame_callback_->PostAbort();
 }
 
 void VideoSourceResource::OnPluginMsgOpenComplete(
     const ResourceMessageReplyParams& reply_params) {
   if (TrackedCallback::IsPending(open_callback_)) {
     int32_t result = reply_params.result();
     if (result == PP_OK)
       is_open_ = true;
     open_callback_->Run(result);
   }
 }
 
 void VideoSourceResource::OnPluginMsgGetFrameComplete(
     PP_VideoFrame_Private* frame,

[meacer, 2013/06/19 02:05:11]

It seems possible that frame->image_data is not initialized after this method.
Is that okay? Just asking.

[bbudge, 2013/06/19 16:55:00]

Yes, the API contract is that the frame isn't written to unless the function
succeeds. I will add some documentation to that effect in the .idl file for this
API.

     const ResourceMessageReplyParams& reply_params,
     const HostResource& image_data,
     const PP_ImageDataDesc& image_desc,
-    int fd,
     PP_TimeTicks timestamp) {
   // The callback may have been aborted by Close().
   if (TrackedCallback::IsPending(get_frame_callback_)) {
     int32_t result = reply_params.result();
     if (result == PP_OK &&
         PPB_ImageData_Shared::IsImageDataDescValid(image_desc)) {
       frame->timestamp = timestamp;
 
-#if defined(OS_ANDROID)
-      frame->image_data = 0;
-#elif defined(TOOLKIT_GTK)
-      frame->image_data =
-          (new PlatformImageData(image_data, image_desc, fd))->GetReference();
-#elif defined(OS_LINUX) || defined(OS_WIN) || defined(OS_MACOSX)
       base::SharedMemoryHandle handle;
       if (!reply_params.TakeSharedMemoryHandleAtIndex(0, &handle))
         frame->image_data = 0;
       frame->image_data =
-          (new PlatformImageData(
+          (new SimpleImageData(
               image_data, image_desc, handle))->GetReference();
-#else
-#error Not implemented.
-#endif
     }
     get_frame_callback_->Run(result);
   }
 }
 
 }  // namespace proxy
 }  // namespace ppapi