Issue 16335005: Revert 14915 and 14916

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16335005: Revert 14915 and 14916 (Closed)

Created:
7 years, 6 months ago by danno

Modified:
7 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert 14916: Mark test-cpu-profiler/SampleWhenFrameIsNotSetup as flaky on MIPS simulator Revert 14915: CPU profiler should support names of accessors set via v8::Object::SetAccessor Due to Windows failures R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14918

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -157 lines)			Patch
M	src/objects.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+0 lines, -147 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

7 years, 6 months ago (2013-06-03 15:25:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14918 (presubmit successful).

Expand Messages | Collapse Messages