Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1633413003: Fix Windows build (Closed)

Created:
4 years, 11 months ago by yujieqin
Modified:
4 years, 11 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, adaubert, ebrauer
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove gyp change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/codec/SkRawCodec.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yujieqin
4 years, 11 months ago (2016-01-27 16:49:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633413003/20001
4 years, 11 months ago (2016-01-27 16:51:13 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-27 16:51:14 UTC) #8
scroggo
lgtm
4 years, 11 months ago (2016-01-27 16:52:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633413003/20001
4 years, 11 months ago (2016-01-27 16:53:15 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:03:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fda27a977d4dde37792f675686e8ff977b41958c

Powered by Google App Engine
This is Rietveld 408576698