Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1633413002:
Add Dr. Fuzz config into tools/mb/mb_config.pyl (Closed)
DescriptionAdd Dr. Fuzz config into tools/mb/mb_config.pyl
This CL adds Dr. Fuzz config in mb_config.pyl to support building
tests for Dr. Memory and Dr. Fuzz on Windows.
R=dpranke@chromium.org
BUG=572694
Committed: https://crrev.com/67793de9edbe1a8aa9d181d14121a80775ec1b11
Cr-Commit-Position: refs/heads/master@{#372021}
Patch Set 1 #
Total comments: 5
Messages
Total messages: 19 (6 generated)
The CQ bit was checked by zhaoqin@google.com to run a CQ dry run
Description was changed from ========== Add Dr. Fuzz config into tools/mb/mb_config.pyl This CL adds Dr. Fuzz config in mb_config.pyl to support building tests for Dr. Memory and Dr. Fuzz on Windows. R=dpranke@chromium.org BUG=572694 ========== to ========== Add Dr. Fuzz config into tools/mb/mb_config.pyl This CL adds Dr. Fuzz config in mb_config.pyl to support building tests for Dr. Memory and Dr. Fuzz on Windows. R=dpranke@chromium.org BUG=572694 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633413002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Is there a good way to test the CL? https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:414: 'gn_args': 'is_component_build=true enable_iterator_debugging=false', actually, I am not sure if enable_iterator_debugging=false really maps to build_for_tool=drmemory. I found that mapping from https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo... However, according to: https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&... build_for_tool=drmemory need tweak several options for running Dr. Memory properly. https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD... enable_iterator_debugging=false probably only handles the win_debug_disable_iterator_debugging, not other tweaks.
On 2016/01/27 04:24:09, commit-bot: I haz the power wrote: > Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are > accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Interesting, I thought I was full committer for years.
https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:411: 'drfuzz': { 'gn_args': 'use_drfuzz=true' }, is there a matching GYP equivalent for this? https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:414: 'gn_args': 'is_component_build=true enable_iterator_debugging=false', Honestly, I have no idea what this will do. I'm happy to let this go through as-is and we can test things and see if they are being built right, but if you like we can also try to dig into the actual GN and GYP files and see if this is right or if we need other things as well.
On 2016/01/27 04:28:16, zhaoqin wrote: > On 2016/01/27 04:24:09, commit-bot: I haz the power wrote: > > Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are > > accepted. > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > See http://www.chromium.org/getting-involved/become-a-committer > > Note that this has nothing to do with OWNERS files. > > Interesting, I thought I was full committer for years. You are a full committer, but under zhaoqin@chromium.org, not zhaoqin@google.com (which is what this was uploaded as). In addition, the error message is actually saying that you didn't get an approval from *anyone at all*, which is separate from whether or not you are a committer :).
On Jan 27, 2016 7:30 PM, "dpranke@chromium.org via codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com> wrote: > > > https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:411: 'drfuzz': { 'gn_args': 'use_drfuzz=true' }, > is there a matching GYP equivalent for this? > > https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:414: 'gn_args': 'is_component_build=true > enable_iterator_debugging= > false', > Honestly, I have no idea what this will do. I'm happy to let this go > through as-is and we can test things and see if they are being built > right, but if you like we can also try to dig into the actual GN and GYP > files and see if this is right or if we need other things as well. We can fisrt commit it if get l-g-t-m and then dig into it meanwhile. > > https://codereview.chromium.org/1633413002/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
ok. lgtm.
https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:411: 'drfuzz': { 'gn_args': 'use_drfuzz=true' }, On 2016/01/28 00:30:49, Dirk Pranke wrote: > is there a matching GYP equivalent for this? no, that was added for building fuzzers on Windows without libfuzzer. All those fuzzers seem can only build via GN. https://codereview.chromium.org/1633413002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:414: 'gn_args': 'is_component_build=true enable_iterator_debugging=false', On 2016/01/28 00:30:48, Dirk Pranke wrote: > Honestly, I have no idea what this will do. I'm happy to let this go through > as-is and we can test things and see if they are being built right, but if you > like we can also try to dig into the actual GN and GYP files and see if this is > right or if we need other things as well. Acknowledged.
The CQ bit was checked by zhaoqin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633413002/1
Message was sent while issue was closed.
Description was changed from ========== Add Dr. Fuzz config into tools/mb/mb_config.pyl This CL adds Dr. Fuzz config in mb_config.pyl to support building tests for Dr. Memory and Dr. Fuzz on Windows. R=dpranke@chromium.org BUG=572694 ========== to ========== Add Dr. Fuzz config into tools/mb/mb_config.pyl This CL adds Dr. Fuzz config in mb_config.pyl to support building tests for Dr. Memory and Dr. Fuzz on Windows. R=dpranke@chromium.org BUG=572694 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add Dr. Fuzz config into tools/mb/mb_config.pyl This CL adds Dr. Fuzz config in mb_config.pyl to support building tests for Dr. Memory and Dr. Fuzz on Windows. R=dpranke@chromium.org BUG=572694 ========== to ========== Add Dr. Fuzz config into tools/mb/mb_config.pyl This CL adds Dr. Fuzz config in mb_config.pyl to support building tests for Dr. Memory and Dr. Fuzz on Windows. R=dpranke@chromium.org BUG=572694 Committed: https://crrev.com/67793de9edbe1a8aa9d181d14121a80775ec1b11 Cr-Commit-Position: refs/heads/master@{#372021} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/67793de9edbe1a8aa9d181d14121a80775ec1b11 Cr-Commit-Position: refs/heads/master@{#372021} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
