Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: ui/views/window/dialog_delegate.cc

Issue 1633403002: MacViews: Add native drop shadow to dialogs on OSX < 10.10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/cocoa/bridged_native_widget.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_delegate.cc
diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc
index 64759d95c3fb38e284f5ce976eff52c137bd8858..e6b179e538ae26e2f385864063a042d7d8560324 100644
--- a/ui/views/window/dialog_delegate.cc
+++ b/ui/views/window/dialog_delegate.cc
@@ -200,12 +200,7 @@ NonClientFrameView* DialogDelegate::CreateDialogFrameView(Widget* widget) {
new BubbleFrameView(gfx::Insets(kPanelVertMargin, kButtonHEdgeMarginNew,
0, kButtonHEdgeMarginNew),
gfx::Insets());
-#if defined(OS_MACOSX)
- // On Mac, dialogs have no border stroke and use a shadow provided by the OS.
- const BubbleBorder::Shadow kShadow = BubbleBorder::NO_ASSETS;
-#else
const BubbleBorder::Shadow kShadow = BubbleBorder::SMALL_SHADOW;
-#endif
scoped_ptr<BubbleBorder> border(
new BubbleBorder(BubbleBorder::FLOAT, kShadow, gfx::kPlaceholderColor));
border->set_use_theme_background_color(true);
« no previous file with comments | « ui/views/cocoa/bridged_native_widget.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698