Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: ui/gfx/path_mac.mm

Issue 1633403002: MacViews: Add native drop shadow to dialogs on OSX < 10.10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/path_mac.h ('k') | ui/gfx/path_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/path_mac.mm
diff --git a/ui/gfx/path_mac.mm b/ui/gfx/path_mac.mm
new file mode 100644
index 0000000000000000000000000000000000000000..109f80741f4099ceea697953ac425e92719ed7de
--- /dev/null
+++ b/ui/gfx/path_mac.mm
@@ -0,0 +1,125 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ui/gfx/path_mac.h"
+
+#import <Cocoa/Cocoa.h>
+
+#include "third_party/skia/include/core/SkRegion.h"
+#include "ui/gfx/path.h"
+
+namespace {
+
+// Convert a quadratic bezier curve to a cubic bezier curve. Based on the
+// implementation of the private SkConvertQuadToCubic method inside Skia.
+void ConvertQuadToCubicBezier(NSPoint quad[3], NSPoint cubic[4]) {
+ // The resultant cubic will have the same endpoints.
+ cubic[0] = quad[0];
+ cubic[3] = quad[2];
+
+ const double scale = 2.0 / 3.0;
+
+ cubic[1].x = quad[0].x + scale * (quad[1].x - quad[0].x);
+ cubic[1].y = quad[0].y + scale * (quad[1].y - quad[0].y);
+
+ cubic[2].x = quad[2].x + scale * (quad[1].x - quad[2].x);
+ cubic[2].y = quad[2].y + scale * (quad[1].y - quad[2].y);
+}
+
+} // namespace
+
+namespace gfx {
+
+NSBezierPath* CreateNSBezierPathFromSkPath(const SkPath& path) {
+ NSBezierPath* result = [NSBezierPath bezierPath];
+ SkPath::RawIter iter(path);
+ SkPoint sk_points[4] = {{0.0}};
+ SkPath::Verb verb;
+ NSPoint points[4];
+ while ((verb = iter.next(sk_points)) != SkPath::kDone_Verb) {
+ for (size_t i = 0; i < arraysize(points); i++)
+ points[i] = NSMakePoint(sk_points[i].x(), sk_points[i].y());
+
+ switch (verb) {
+ case SkPath::kMove_Verb: {
+ [result moveToPoint:points[0]];
+ break;
+ }
+ case SkPath::kLine_Verb: {
+ DCHECK(NSEqualPoints([result currentPoint], points[0]));
+ [result lineToPoint:points[1]];
+ break;
+ }
+ case SkPath::kQuad_Verb: {
+ DCHECK(NSEqualPoints([result currentPoint], points[0]));
+ NSPoint quad[] = {points[0], points[1], points[2]};
+ // NSBezierPath does not support quadratic bezier curves. Hence convert
+ // to cubic bezier curve.
+ ConvertQuadToCubicBezier(quad, points);
+ [result curveToPoint:points[3]
+ controlPoint1:points[1]
+ controlPoint2:points[2]];
+ break;
+ }
+ case SkPath::kConic_Verb: {
+ DCHECK(NSEqualPoints([result currentPoint], points[0]));
+ // Approximate with quads. Use two for now, increase if more precision
+ // is needed.
+ const size_t kSubdivisionLevels = 1;
+ const size_t kQuadCount = 1 << kSubdivisionLevels;
+ // The quads will share endpoints, so we need one more point than twice
+ // the number of quads.
+ const size_t kPointCount = 1 + 2 * kQuadCount;
+ SkPoint quads[kPointCount];
+ SkPath::ConvertConicToQuads(sk_points[0], sk_points[1], sk_points[2],
+ iter.conicWeight(), quads,
+ kSubdivisionLevels);
+ NSPoint ns_quads[kPointCount];
+ for (size_t i = 0; i < kPointCount; i++)
+ ns_quads[i] = NSMakePoint(quads[i].x(), quads[i].y());
+
+ for (size_t i = 0; i < kQuadCount; i++) {
+ NSPoint quad[] = {ns_quads[2 * i], ns_quads[2 * i + 1],
+ ns_quads[2 * i + 2]};
+ ConvertQuadToCubicBezier(quad, points);
+ DCHECK(NSEqualPoints([result currentPoint], points[0]));
+ [result curveToPoint:points[3]
+ controlPoint1:points[1]
+ controlPoint2:points[2]];
+ }
+ break;
+ }
+ case SkPath::kCubic_Verb: {
+ DCHECK(NSEqualPoints([result currentPoint], points[0]));
+ [result curveToPoint:points[3]
+ controlPoint1:points[1]
+ controlPoint2:points[2]];
+ break;
+ }
+ case SkPath::kClose_Verb: {
+ [result closePath];
+ break;
+ }
+ default: { NOTREACHED(); }
+ }
+ }
+
+ // Set up the fill type.
+ switch (path.getFillType()) {
+ case SkPath::kWinding_FillType:
+ [result setWindingRule:NSNonZeroWindingRule];
+ break;
+ case SkPath::kEvenOdd_FillType:
+ [result setWindingRule:NSEvenOddWindingRule];
+ break;
+ case SkPath::kInverseWinding_FillType:
+ case SkPath::kInverseEvenOdd_FillType:
+ NOTREACHED() << "NSBezierCurve does not support inverse fill types.";
+ break;
+ }
+
+ return result;
+}
+
+} // namespace gfx
« no previous file with comments | « ui/gfx/path_mac.h ('k') | ui/gfx/path_mac_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698