ui/views/widget/native_widget_mac.mm - Issue 1633403002: MacViews: Add native drop shadow to dialogs on OSX < 10.10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 1633403002: MacViews: Add native drop shadow to dialogs on OSX < 10.10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Review comments. Added unit tests for NativeWidgetMac::SchedulePaintInRect Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/cocoa/bridged_content_view.mm ('K') | « ui/views/cocoa/bridged_native_widget.mm ('k') | ui/views/widget/native_widget_mac_unittest.mm » ('j') | ui/views/widget/native_widget_mac_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/native_widget_mac.mm

diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm

index e34f61d29a401810224eab5a67c3bf6cf9689f99..8ee2a6d7de3021510f2d1474f400b85a11a01558 100644

--- a/ui/views/widget/native_widget_mac.mm

+++ b/ui/views/widget/native_widget_mac.mm

@@ -502,9 +502,15 @@ void NativeWidgetMac::RunShellDrag(View* view,

}

void NativeWidgetMac::SchedulePaintInRect(const gfx::Rect& rect) {

- // TODO(tapted): This should use setNeedsDisplayInRect:, once the coordinate

- // system of |rect| has been converted.

- [GetNativeView() setNeedsDisplay:YES];

+ // |rect| is relative to client area of the window.

+ NSWindow* window = GetNativeWindow();

+ NSRect client_rect = [window contentRectForFrameRect:[window frame]];

+ NSRect target_rect = rect.ToCGRect();

+ // Convert to Appkit coordinate system (origin at bottom left).

+ target_rect.origin.y =

+ NSHeight(client_rect) - target_rect.origin.y - NSHeight(target_rect);

+ [GetNativeView() setNeedsDisplayInRect:target_rect];

if (bridge_ && bridge_->layer())

bridge_->layer()->SchedulePaint(rect);

}