ui/gfx/path_mac.h - Issue 1633403002: MacViews: Add native drop shadow to dialogs on OSX < 10.10.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/path_mac.h

Issue 1633403002: MacViews: Add native drop shadow to dialogs on OSX < 10.10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_PATH_MAC_H_

	6 #define UI_GFX_PATH_MAC_H_

	7

	8 #include "ui/gfx/gfx_export.h"

	9

	10 @class NSBezierPath;

	11 class SkPath;

	12

	13 namespace gfx {

	14

	15 // Returns the NSBezierPath corresponding to \|path\|.
	msw 2016/02/11 23:57:37 nit: document ownership (or need to CFRelease, or nit: document ownership (or need to CFRelease, or similar). Maybe return a base::scoped_nsobject or similar? karandeepb 2016/02/12 03:45:51 Done. Have documented that this returns an autorel Show quoted text On 2016/02/11 23:57:37, msw wrote: > nit: document ownership (or need to CFRelease, or similar). > Maybe return a base::scoped_nsobject or similar? Done. Have documented that this returns an autoreleased pointer, which can be retained by the caller if needed. Don't think we should return a base::scoped_nsobject. It's conventional to return autoreleased pointers on Mac and use base::scoped_nsobjects as part of method arguments, when we need to transfer ownership. msw 2016/02/12 19:26:55 I'm not familiar with this convention, but I'll tr Show quoted text On 2016/02/12 03:45:51, karandeepb wrote: > On 2016/02/11 23:57:37, msw wrote: > > nit: document ownership (or need to CFRelease, or similar). > > Maybe return a base::scoped_nsobject or similar? > > Done. Have documented that this returns an autoreleased pointer, which can be > retained by the caller if needed. Don't think we should return a > base::scoped_nsobject. It's conventional to return autoreleased pointers on Mac > and use base::scoped_nsobjects as part of method arguments, when we need to > transfer ownership. I'm not familiar with this convention, but I'll trust you and Trent on it.
	16 GFX_EXPORT NSBezierPath* CreateNSBezierPathFromSkPath(const SkPath& path);

	17

	18 } // namespace gfx

	19

	20 #endif // UI_GFX_PATH_MAC_H_

OLD	NEW

« no previous file with comments | « ui/gfx/gfx_tests.gyp ('k') | ui/gfx/path_mac.mm » ('j') | ui/gfx/path_mac.mm » ('J')