Remove NPAPI Flash migration code.

chrome/browser/plugins/plugin_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_prefs.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 41 matching lines @@
     if (PathService::Get(chrome::DIR_COMPONENT_UPDATED_PEPPER_FLASH_PLUGIN,
                          &component_updated_pepper_flash_dir) &&
         component_updated_pepper_flash_dir.IsParent(plugin)) {
       return true;
     }
   }
 
   return false;
 }
 
-// Returns true if |path| looks like the path to an NPAPI Flash plugin.
-bool IsNpapiFlashPath(const base::FilePath& path) {
-  base::FilePath npapi_flash;
-  // Check NPAPI Flash is installed.
-  if (!PathService::Get(chrome::FILE_FLASH_SYSTEM_PLUGIN, &npapi_flash))
-    return false;
-  // Check for same architecture NPAPI Flash.
-  if (base::FilePath::CompareEqualIgnoreCase(path.value(), npapi_flash.value()))
-    return true;
-#if defined(OS_WIN)
-  // Fuzzy check for NPAPI Flash on Windows.
-  base::FilePath::StringType kSwfPrefix = FILE_PATH_LITERAL("NPSWF");
-  if (path.BaseName().value().compare(0, kSwfPrefix.size(), kSwfPrefix) == 0)
-    return true;
-#endif
-  return false;
-}
-
 }  // namespace
 
 PluginPrefs::PluginState::PluginState() {
 }
 
 PluginPrefs::PluginState::~PluginState() {
 }
 
 bool PluginPrefs::PluginState::Get(const base::FilePath& plugin,
                                    bool* enabled) const {
@@ skipping 249 matching lines @@
   base::FilePath last_internal_dir =
       prefs_->GetFilePath(prefs::kPluginsLastInternalDirectory);
   base::FilePath cur_internal_dir;
   if (PathService::Get(chrome::DIR_INTERNAL_PLUGINS, &cur_internal_dir) &&
       cur_internal_dir != last_internal_dir) {
     update_internal_dir = true;
     prefs_->SetFilePath(
         prefs::kPluginsLastInternalDirectory, cur_internal_dir);
   }
 
-  bool migrate_to_pepper_flash = false;
-#if defined(OS_WIN) || defined(OS_MACOSX)
-  // If NPAPI Flash is enabled while Pepper Flash is disabled, we would like to
-  // turn Pepper Flash on. And we want to do it once, when NPAPI is disabled in
-  // Chrome 45.
-  // TODO(wfh): Remove this code once it has been run by most users, around
-  // Chrome 49 or Chrome 50. See crbug.com/514250.
-  if (!prefs_->GetBoolean(prefs::kNpapiFlashMigratedToPepperFlash)) {
-    prefs_->SetBoolean(prefs::kNpapiFlashMigratedToPepperFlash, true);
-    migrate_to_pepper_flash = true;
-  }
-#endif
-
   {  // Scoped update of prefs::kPluginsPluginsList.
     ListPrefUpdate update(prefs_, prefs::kPluginsPluginsList);
     base::ListValue* saved_plugins_list = update.Get();
     if (saved_plugins_list && !saved_plugins_list->empty()) {
-      // The following four variables are only valid when
-      // |migrate_to_pepper_flash| is set to true.
-      base::FilePath pepper_flash;
-      base::DictionaryValue* pepper_flash_node = NULL;
-      bool npapi_flash_enabled = false;
-      if (migrate_to_pepper_flash) {
-        PathService::Get(chrome::FILE_PEPPER_FLASH_PLUGIN, &pepper_flash);
-      }
-
-      for (base::ListValue::iterator it = saved_plugins_list->begin();
-           it != saved_plugins_list->end();
-           ++it) {
-        if (!(*it)->IsType(base::Value::TYPE_DICTIONARY)) {
+      for (base::Value* plugin_value : *saved_plugins_list) {
+        if (!plugin_value->IsType(base::Value::TYPE_DICTIONARY)) {
           LOG(WARNING) << "Invalid entry in " << prefs::kPluginsPluginsList;
           continue;  // Oops, don't know what to do with this item.
         }
 
         base::DictionaryValue* plugin =
-            static_cast<base::DictionaryValue*>(*it);
+            reinterpret_cast<base::DictionaryValue*>(plugin_value);

[Will Harris, 2016/01/27 02:17:01]

some code uses reinterpret_cast and some uses static_cast here. I chose
reinterpret...

[Bernhard Bauer, 2016/01/27 15:51:43]

Urr... no, I think static_cast is the correct one here. reinterpret_cast
literally means "interpret this pointer as that pointer", which would get e.g.
vtable offsets wrong, whereas static_cast will do the necessary adjustments and
also check that the types are in a subtype relation.

[Will Harris, 2016/01/27 17:03:51]

okay thanks! Should go and fix these or are these safe?

https://code.google.com/p/chromium/codesearch#search/&q=%22reinterpret_cast%3...

[Bernhard Bauer, 2016/01/27 17:08:38]

Uh, both? 😄 I think they are effectively safe for DictionaryValue because there
is no vtable adjustment necessary, but static_cast is more idiomatic, and safer
if someone tries to do this for other types, so it would be nice to fix the
others. Thanks!

         base::string16 group_name;
         bool enabled;
         if (!plugin->GetBoolean("enabled", &enabled))
           enabled = true;
 
         base::FilePath::StringType path;
         // The plugin list constains all the plugin files in addition to the
         // plugin groups.
         if (plugin->GetString("path", &path)) {
           // Files have a path attribute, groups don't.
@@ skipping 31 matching lines @@
 
             // If |relative_path| is empty, |plugin_path| is not within
             // |last_internal_dir|. We don't need to update it.
             if (!relative_path.empty()) {
               plugin_path = cur_internal_dir.Append(relative_path);
               path = plugin_path.value();
               plugin->SetString("path", path);
             }
           }
 
-          if (migrate_to_pepper_flash && IsNpapiFlashPath(plugin_path)) {
-            npapi_flash_enabled = enabled;
-          } else if (migrate_to_pepper_flash &&
-                     base::FilePath::CompareEqualIgnoreCase(
-                         path, pepper_flash.value())) {
-            if (!enabled)
-              pepper_flash_node = plugin;
-          }
-
           plugin_state_.Set(plugin_path, enabled);
         } else if (!enabled && plugin->GetString("name", &group_name)) {
           // Otherwise this is a list of groups.
           plugin_group_state_[group_name] = false;
         }
       }
-
-      if (npapi_flash_enabled && pepper_flash_node) {
-        DCHECK(migrate_to_pepper_flash);
-        pepper_flash_node->SetBoolean("enabled", true);
-        plugin_state_.Set(pepper_flash, true);
-      }
     } else {
       // If the saved plugin list is empty, then the call to UpdatePreferences()
       // below failed in an earlier run, possibly because the user closed the
       // browser too quickly.
 
       // Only want one PDF plugin enabled at a time. See http://crbug.com/50105
       // for background.
       plugin_group_state_[base::ASCIIToUTF16(
           PluginMetadata::kAdobeReaderGroupName)] = false;
     }
@@ skipping 101 matching lines @@
   }
 }
 
 void PluginPrefs::NotifyPluginStatusChanged() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED,
       content::Source<Profile>(profile_),
       content::NotificationService::NoDetails());
 }