Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 163333003: (Pre)Parser: Move ParsePrimaryExpression to ParserBase. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

(Pre)Parser: Move ParsePrimaryExpression to ParserBase. Notes: - To be able to move the recursive descent functions to ParserBase one at a time, we temporarily need routing functions from traits to Parser/PreParser, since the recursive descent functions form a cyclic structure. - PreParser used to always allow intrinsic syntax. After this CL, it depends on allow_natives_syntax() which was already in ParserBase. - This CL also decouples (Pre)ParserTraits better from (Pre)Parser, passing more information as parameters, so that the Traits don't need to get it from (Pre)Parser. R=ulan@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19374

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : moar #

Patch Set 4 : . #

Patch Set 5 : #

Patch Set 6 : ws #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -243 lines) Patch
M src/parser.h View 1 2 3 chunks +20 lines, -4 lines 0 comments Download
M src/parser.cc View 1 2 4 chunks +84 lines, -125 lines 0 comments Download
M src/preparser.h View 1 2 3 4 5 13 chunks +147 lines, -11 lines 0 comments Download
M src/preparser.cc View 1 2 3 4 5 chunks +38 lines, -102 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 10 months ago (2014-02-14 09:45:48 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-14 11:17:38 UTC) #2
marja
6 years, 10 months ago (2014-02-14 11:24:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r19374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698