Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1633283002: cc: remove unused texture rect params, functions. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: remove unused texture rect params, functions. Looks like the target_rect param to BindFramebufferToTexture is now unused. And it looks like UseScopedTexture is entirely unused. Remove them both. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d195bafa7b5ba5798253db60ff5f50c5154a6823 Cr-Commit-Position: refs/heads/master@{#371632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M cc/output/direct_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.h View 2 chunks +1 line, -6 lines 0 comments Download
M cc/output/gl_renderer.cc View 2 chunks +1 line, -12 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Stephen White
danakj@: PTAL. Thanks!
4 years, 11 months ago (2016-01-26 22:10:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633283002/1
4 years, 11 months ago (2016-01-26 22:12:22 UTC) #6
danakj
LGTM
4 years, 11 months ago (2016-01-26 22:18:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633283002/1
4 years, 11 months ago (2016-01-26 22:22:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 23:27:38 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 23:29:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d195bafa7b5ba5798253db60ff5f50c5154a6823
Cr-Commit-Position: refs/heads/master@{#371632}

Powered by Google App Engine
This is Rietveld 408576698