Stop creating duplicate enum members when the element model has already been built

Stop creating duplicate enum members when the element model has already been built

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c56d057461727d79098b583b4505eb9c01c79c7

[Brian Wilkerson, 2016-01-26 21:38:53]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-01-26 21:38:53]

This might account for some of our stability issues. In either case it's clearly
wrong to have duplicate elements.

[scheglov, 2016-01-26 21:51:04]

LGTM

https://codereview.chromium.org/1633233002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1633233002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:1242: EnumDeclaration firstEnum =
findFirstEnum();
This could be done with less code.
    EnumDeclaration firstEnum = unit.declarations
        .firstWhere((member) => member is EnumDeclaration, orElse: () => null);

[Brian Wilkerson, 2016-01-26 21:59:42]

https://codereview.chromium.org/1633233002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1633233002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:1242: EnumDeclaration firstEnum =
findFirstEnum();
I discovered firstWhere, but didn't notice the orElse. Unless you care a lot, I
think I'll just leave it at this point; it doesn't get rid of as much code as I
would have liked.

[Brian Wilkerson, 2016-01-26 22:00:11]

Description was changed from

==========
Stop creating duplicate enum members when the element model has already been
built
==========

to

==========
Stop creating duplicate enum members when the element model has already been
built

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c56d057461727d79098b583b4505eb9c01c79c7
==========

[Brian Wilkerson, 2016-01-26 22:00:14]

Committed patchset #1 (id:1) manually as
9c56d057461727d79098b583b4505eb9c01c79c7 (presubmit successful).