Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1633043004: cc: Fix bug where tabs have the wrong scale factor (Closed)

Created:
4 years, 11 months ago by ccameron
Modified:
4 years, 11 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix bug where tabs have the wrong scale factor Device scale factor impacts the draw properties (in particular, the transforms of the TransformNodes in the property tree). So, mark that draw properties need to be updated when device scale factor changes. BUG=567832 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a65c79bc20f5ec529973d953d358e3db560a02e9 Cr-Commit-Position: refs/heads/master@{#371659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ccameron
I guess this turned out not to be terribly complicated.
4 years, 11 months ago (2016-01-26 22:38:01 UTC) #3
enne (OOO)
lgtm
4 years, 11 months ago (2016-01-26 22:43:29 UTC) #5
ccameron
Thanks!
4 years, 11 months ago (2016-01-26 22:44:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633043004/1
4 years, 11 months ago (2016-01-26 22:44:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:25:43 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:26:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a65c79bc20f5ec529973d953d358e3db560a02e9
Cr-Commit-Position: refs/heads/master@{#371659}

Powered by Google App Engine
This is Rietveld 408576698