Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: tool/input_sdk/private/debugger.dart

Issue 1633003002: Add --modules=node support (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: merged master Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/lib/html/html_common/html_common_ddc.dart ('k') | tool/input_sdk/private/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/debugger.dart
diff --git a/tool/input_sdk/private/debugger.dart b/tool/input_sdk/private/debugger.dart
index 88ad1ae55069ab4a2bb4b01337cb12366c3b832b..2a8a877824da243e281a72550348d4986c02d17e 100644
--- a/tool/input_sdk/private/debugger.dart
+++ b/tool/input_sdk/private/debugger.dart
@@ -18,8 +18,8 @@ final int maxIterableChildrenToDisplay = 50;
var _devtoolsFormatter = new JsonMLFormatter(new DartFormatter());
-String typeof(object) => JS('String', 'typeof #', object);
-bool instanceof(object, clazz) => JS('bool', '# instanceof #', object, clazz);
+String _typeof(object) => JS('String', 'typeof #', object);
+bool _instanceof(object, clazz) => JS('bool', '# instanceof #', object, clazz);
List<String> getOwnPropertyNames(object) =>
dart.list(JS('List', 'Object.getOwnPropertyNames(#)', object), String);
@@ -37,14 +37,14 @@ class JSNative {
}
bool isRegularDartObject(object) {
- if (typeof(object) == 'function') return false;
- return instanceof(object, Object);
+ if (_typeof(object) == 'function') return false;
+ return _instanceof(object, Object);
}
String getObjectTypeName(object) {
var realRuntimeType = dart.realRuntimeType(object);
if (realRuntimeType == null) {
- if (typeof(object) == 'function') {
+ if (_typeof(object) == 'function') {
return '[[Raw JavaScript Function]]';
}
return '<Error getting type name>';
@@ -209,8 +209,8 @@ class JsonMLFormatter {
var nameSpan = new JsonMLElement('span')
..createTextChild(child.name != null ? child.name + ': ' : '')
..setStyle('color: rgb(136, 19, 145);');
- if (typeof(child.value) == 'object' ||
- typeof(child.value) == 'function') {
+ if (_typeof(child.value) == 'object' ||
+ _typeof(child.value) == 'function') {
nameSpan.addStyle("padding-left: 13px;");
li.appendChild(nameSpan);
@@ -356,7 +356,7 @@ class ObjectFormatter extends Formatter {
/// runtime type information.
class FunctionFormatter extends Formatter {
accept(object) {
- if (typeof(object) != 'function') return false;
+ if (_typeof(object) != 'function') return false;
return dart.realRuntimeType(object) != null;
}
« no previous file with comments | « tool/input_sdk/lib/html/html_common/html_common_ddc.dart ('k') | tool/input_sdk/private/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698