Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: lib/src/codegen/js_names.dart

Issue 1633003002: Add --modules=node support (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: reverted let->const parasite change Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/codegen/js_names.dart
diff --git a/lib/src/codegen/js_names.dart b/lib/src/codegen/js_names.dart
index c84991f6be1f40d124e284be69edac8ded985dc3..a07b1f727a1b8ae2060996feddda83e804c85b39 100644
--- a/lib/src/codegen/js_names.dart
+++ b/lib/src/codegen/js_names.dart
@@ -281,6 +281,12 @@ bool invalidVariableName(String keyword, {bool strictMode: true}) {
case "static":
case "yield":
return strictMode;
+
+ // Node refuses these:
Jennifer Messerly 2016/01/29 00:32:31 Any more info on these? What's the error message s
ochafik 2016/01/29 09:38:17 Dropped these, not needed now...
+ case "async":
Jennifer Messerly 2016/01/29 00:32:31 this could be related to https://tc39.github.io/ec
ochafik 2016/01/29 09:38:17 My bad, now fixed (I had a weird collision of asyn
+ case "dynamic":
+ case "void":
Jennifer Messerly 2016/01/29 00:32:31 it looks like "void" is already covered, above? So
ochafik 2016/01/29 09:38:17 Done.
+ return true;
}
return false;
}

Powered by Google App Engine
This is Rietveld 408576698