tool/input_sdk/private/classes.dart - Issue 1633003002: Add --modules=node support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/classes.dart

Issue 1633003002: Add --modules=node support (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: regen sdk and expectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/classes.dart

diff --git a/tool/input_sdk/private/classes.dart b/tool/input_sdk/private/classes.dart

index 7a784a4257c321f8ed92d193a05ddaca7ac5034c..930a83abf9ed1749d66f396ff787654a93c139fd 100644

--- a/tool/input_sdk/private/classes.dart

+++ b/tool/input_sdk/private/classes.dart

@@ -282,6 +282,8 @@ registerExtension(jsType, dartExtType) => JS('', '''(() => {

$assert_(jsProto[$_extensionType] === void 0);

jsProto[$_extensionType] = extProto;

+ // TODO(ochafik): Fix this (DO NOT SUBMIT)

+ //let dartObjProto = require('dart/core').Object.prototype; // \$Object.prototype;

vsm 2016/01/26 14:09:41 Remove?

ochafik 2016/01/26 16:27:37 Done.

let dartObjProto = $Object.prototype;

while (extProto !== dartObjProto && extProto !== jsProto) {

$copyTheseProperties(jsProto, extProto, $getOwnPropertySymbols(extProto));