Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/codegen/js_names.dart

Issue 1633003002: Add --modules=node support (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: regen sdk and expectations Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | lib/src/codegen/module_builder.dart » ('j') | lib/src/codegen/module_builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_names.dart
diff --git a/lib/src/codegen/js_names.dart b/lib/src/codegen/js_names.dart
index c84991f6be1f40d124e284be69edac8ded985dc3..a07b1f727a1b8ae2060996feddda83e804c85b39 100644
--- a/lib/src/codegen/js_names.dart
+++ b/lib/src/codegen/js_names.dart
@@ -281,6 +281,12 @@ bool invalidVariableName(String keyword, {bool strictMode: true}) {
case "static":
case "yield":
return strictMode;
+
+ // Node refuses these:
+ case "async":
+ case "dynamic":
+ case "void":
+ return true;
}
return false;
}
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | lib/src/codegen/module_builder.dart » ('j') | lib/src/codegen/module_builder.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698