test/codegen_test.dart - Issue 1633003002: Add --modules=node support - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(162)

My Issues | Starred Open | Closed | All

Unified Diff: test/codegen_test.dart

Issue 1633003002: Add --modules=node support (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: regen sdk and expectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« lib/src/compiler.dart ('K') | « test/codegen/node_modules.dart ('k') | test/utils_test.dart » ('j') | tool/input_sdk/lib/html/ddc/html_ddc.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/codegen_test.dart

diff --git a/test/codegen_test.dart b/test/codegen_test.dart

index fbda6fb704217f7ebea71601ae4f519bef4b8099..febd7a9ec6119343998c09de0a71c46b7fc2a6a4 100644

--- a/test/codegen_test.dart

+++ b/test/codegen_test.dart

@@ -151,8 +151,11 @@ $compilerMessages''';

// We need a more comprehensive strategy to test them.

var sourceMaps = filename == 'map_keys';

var closure = filename == 'closure';

- var moduleFormat =

- filename == 'es6_modules' ? ModuleFormat.es6 : ModuleFormat.legacy;

+ var moduleFormat = filename == 'es6_modules'

+ ? ModuleFormat.es6

+ : filename == 'node_modules'

+ ? ModuleFormat.node

+ : ModuleFormat.legacy;

var success;

// TODO(vsm): Is it okay to reuse the same context here? If there is

// overlap between test files, we may need separate ones for each

« lib/src/compiler.dart ('K') | « test/codegen/node_modules.dart ('k') | test/utils_test.dart » ('j') | tool/input_sdk/lib/html/ddc/html_ddc.dart » ('J')

Powered by Google App Engine

This is Rietveld 408576698