Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1632993003: Revert of Type Feedback Vector lives in the closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/factory.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1194 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 1205
1206 1206
1207 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1207 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1208 bool pretenure) { 1208 bool pretenure) {
1209 // Use the fast case closure allocation code that allocates in new 1209 // Use the fast case closure allocation code that allocates in new
1210 // space for nested functions that don't need literals cloning. If 1210 // space for nested functions that don't need literals cloning. If
1211 // we're running with the --always-opt or the --prepare-always-opt 1211 // we're running with the --always-opt or the --prepare-always-opt
1212 // flag, we need to use the runtime function so that the new function 1212 // flag, we need to use the runtime function so that the new function
1213 // we are creating here gets a chance to have its code optimized and 1213 // we are creating here gets a chance to have its code optimized and
1214 // doesn't just get a copy of the existing unoptimized code. 1214 // doesn't just get a copy of the existing unoptimized code.
1215 if (!FLAG_always_opt && !FLAG_prepare_always_opt && !pretenure && 1215 if (!FLAG_always_opt &&
1216 scope()->is_function_scope()) { 1216 !FLAG_prepare_always_opt &&
1217 !pretenure &&
1218 scope()->is_function_scope() &&
1219 info->num_literals() == 0) {
1217 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind()); 1220 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind());
1218 __ mov(r2, Operand(info)); 1221 __ mov(r2, Operand(info));
1219 __ CallStub(&stub); 1222 __ CallStub(&stub);
1220 } else { 1223 } else {
1221 __ Push(info); 1224 __ Push(info);
1222 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured 1225 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured
1223 : Runtime::kNewClosure); 1226 : Runtime::kNewClosure);
1224 } 1227 }
1225 context()->Plug(r0); 1228 context()->Plug(r0);
1226 } 1229 }
(...skipping 3625 matching lines...) Expand 10 before | Expand all | Expand 10 after
4852 DCHECK(interrupt_address == 4855 DCHECK(interrupt_address ==
4853 isolate->builtins()->OsrAfterStackCheck()->entry()); 4856 isolate->builtins()->OsrAfterStackCheck()->entry());
4854 return OSR_AFTER_STACK_CHECK; 4857 return OSR_AFTER_STACK_CHECK;
4855 } 4858 }
4856 4859
4857 4860
4858 } // namespace internal 4861 } // namespace internal
4859 } // namespace v8 4862 } // namespace v8
4860 4863
4861 #endif // V8_TARGET_ARCH_ARM 4864 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698