Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1632983002: [DevTools] Do not reset scroll when emulating device. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not reset scroll when emulating device. We used to reset scroll and page scale factor, now we only reset the latter. Also, reusing mainFrameResizesAreOrientationChanges setting to preserve the scroll position based on DOM node. BUG=581115 Committed: https://crrev.com/d6db426e2e3e06e29e1f0bf0cc435cb3a7acb311 Cr-Commit-Position: refs/heads/master@{#371567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-26 00:37:09 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-26 18:24:00 UTC) #3
paulirish
this is awesome stuff. thanks for trying it out.
4 years, 11 months ago (2016-01-26 18:33:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632983002/1
4 years, 11 months ago (2016-01-26 18:35:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 19:49:12 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 19:49:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6db426e2e3e06e29e1f0bf0cc435cb3a7acb311
Cr-Commit-Position: refs/heads/master@{#371567}

Powered by Google App Engine
This is Rietveld 408576698