Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1632973002:
reland of add remaining unittests to new android bots (Closed)
Descriptionreland of add remaining unittests to new android bots
original cl:
https://codereview.chromium.org/1633713002/
revert:
https://codereview.chromium.org/1639603002/
reason:
broken paths
BUG=514857
Committed: https://crrev.com/cadd78d2d896ca21413fdcc9e649b62b5c6d9d06
Cr-Commit-Position: refs/heads/master@{#371649}
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths BUG=514857 ========== to ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths TBR=jbudorick@chromium.org,martiniss@chromium.org BUG=514857 ==========
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632973002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths TBR=jbudorick@chromium.org,martiniss@chromium.org BUG=514857 ========== to ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths NOPRESUBMIT=true TBR=jbudorick@chromium.org,martiniss@chromium.org BUG=514857 ==========
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632973002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
bpastene@chromium.org changed reviewers: + jbudorick@chromium.org, martiniss@chromium.org, stip@chromium.org
bleh, someone just give me a stamp pls
Description was changed from ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths NOPRESUBMIT=true TBR=jbudorick@chromium.org,martiniss@chromium.org BUG=514857 ========== to ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths BUG=514857 ==========
On 2016/01/26 21:59:15, bpastene wrote: > bleh, someone just give me a stamp pls lgtm in the future, with relands, upload the original as patchset 1 and the fix as patchset 2.
On 2016/01/26 22:06:23, jbudorick wrote: > On 2016/01/26 21:59:15, bpastene wrote: > > bleh, someone just give me a stamp pls > > lgtm > > in the future, with relands, upload the original as patchset 1 and the fix as > patchset 2. Noted
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632973002/1
Message was sent while issue was closed.
Description was changed from ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths BUG=514857 ========== to ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths BUG=514857 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths BUG=514857 ========== to ========== reland of add remaining unittests to new android bots original cl: https://codereview.chromium.org/1633713002/ revert: https://codereview.chromium.org/1639603002/ reason: broken paths BUG=514857 Committed: https://crrev.com/cadd78d2d896ca21413fdcc9e649b62b5c6d9d06 Cr-Commit-Position: refs/heads/master@{#371649} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cadd78d2d896ca21413fdcc9e649b62b5c6d9d06 Cr-Commit-Position: refs/heads/master@{#371649} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
