Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1632963002: webRequest: Check weak ptr before dispatching event (Closed)

Created:
4 years, 11 months ago by robwu
Modified:
4 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webRequest: Check weak ptr before dispatching event BUG=581148 Committed: https://crrev.com/8f63f9e719ca507931a08c708e0663d4573749d9 Cr-Commit-Position: refs/heads/master@{#371418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robwu
4 years, 11 months ago (2016-01-26 00:02:56 UTC) #2
Devlin
lgtm
4 years, 11 months ago (2016-01-26 00:23:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632963002/1
4 years, 11 months ago (2016-01-26 00:26:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 01:57:10 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:58:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f63f9e719ca507931a08c708e0663d4573749d9
Cr-Commit-Position: refs/heads/master@{#371418}

Powered by Google App Engine
This is Rietveld 408576698