Change the TranslateDeclined() to only count decline if the explicit_closed is set to true

chrome/browser/ui/views/translate/translate_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <string>
 #include <utility>
@@ skipping 148 matching lines @@
 
   if (model_->GetViewState() == TranslateBubbleModel::VIEW_STATE_ERROR)
     model_->ShowError(error_type_);
 }
 
 void TranslateBubbleView::ButtonPressed(views::Button* sender,
                                         const ui::Event& event) {
   HandleButtonPressed(static_cast<ButtonID>(sender->id()));
 }
 
 void TranslateBubbleView::WindowClosing() {

[groby-ooo-7-16, 2016/01/26 01:07:22]

This means we would lose all metrics that are due to e.g. page navigation. Do we
want a separate metric for that? Is it OK to do nothing with the model if things
are closed e.g. due to Navigation?

[ftang, 2016/01/26 01:30:35]

The function called "TranslationDeclined()" so no information related to the
real decline of translation will be lost because the function will still be
called when the user really decline the translation. Only information which is
not related to decline of translation will be lost, but such information should
not be tracked inside a function called "TranslationDeclined() anyway. Page
navigation has nothing to do with decline of translation, right?

-  // The operations for |model_| are valid only when a WebContents is alive.
-  // TODO(hajimehoshi): TranslateBubbleViewModel(Impl) should not hold a
-  // WebContents as a member variable because the WebContents might be destroyed
-  // while the TranslateBubbleViewModel(Impl) is still alive. Instead,
-  // TranslateBubbleViewModel should take a reference of a WebContents at each
-  // method. (crbug/320497)
-  if (!translate_executed_ && web_contents())
-    model_->TranslationDeclined(denial_button_clicked_);
-
   // We have to reset |translate_bubble_view_| here, not in our destructor,
   // because we'll be destroyed asynchronously and the shown state will be
   // checked before then.
   DCHECK_EQ(translate_bubble_view_, this);
   translate_bubble_view_ = NULL;
 }
 
 bool TranslateBubbleView::AcceleratorPressed(
     const ui::Accelerator& accelerator) {
   switch (model_->GetViewState()) {
@@ skipping 185 matching lines @@
           model_->SetNeverTranslateLanguage(true);
           break;
         case DenialComboboxIndex::NEVER_TRANSLATE_SITE:
           model_->SetNeverTranslateSite(true);
           break;
         default:
           NOTREACHED();
           break;
       }
       GetWidget()->Close();
+      // The operations for |model_| are valid only when a WebContents is alive.
+      // TODO(hajimehoshi): TranslateBubbleViewModel(Impl) should not hold a
+      // WebContents as a member variable because the WebContents might be
+      // destroyed while the TranslateBubbleViewModel(Impl) is still alive.
+      // Instead,
+      // TranslateBubbleViewModel should take a reference of a WebContents at
+      // each method. (crbug/320497)
+      if (!translate_executed_ && web_contents())
+        model_->TranslationDeclined(denial_button_clicked_);
       break;
     }
     case COMBOBOX_ID_SOURCE_LANGUAGE: {
       if (model_->GetOriginalLanguageIndex() ==
           source_language_combobox_->selected_index()) {
         break;
       }
       model_->UpdateOriginalLanguageIndex(
           source_language_combobox_->selected_index());
       UpdateAdvancedView();
@@ skipping 361 matching lines @@
   base::string16 label;
   if (model_->IsPageTranslatedInCurrentLanguages())
     label = l10n_util::GetStringUTF16(IDS_DONE);
   else
     label = l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ACCEPT);
   advanced_done_button_->SetText(label);
   advanced_done_button_->SizeToPreferredSize();
   if (advanced_view_)
     advanced_view_->Layout();
 }