Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1632943003: impl/prod: Expose Remote API scopes. (Closed)

Created:
4 years, 11 months ago by dnj
Modified:
4 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M impl/prod/context.go View 2 chunks +8 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
dnj
4 years, 11 months ago (2016-01-26 05:20:53 UTC) #1
dnj
https://chromiumcodereview.appspot.com/1632943003/diff/1/impl/prod/context.go File impl/prod/context.go (right): https://chromiumcodereview.appspot.com/1632943003/diff/1/impl/prod/context.go#newcode23 impl/prod/context.go:23: var RemoteAPIScopes = []string{ This is useful when using ...
4 years, 11 months ago (2016-01-26 05:21:35 UTC) #2
iannucci
lgtm
4 years, 11 months ago (2016-01-26 07:02:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632943003/1
4 years, 11 months ago (2016-01-26 07:04:03 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 07:05:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/c955069ae2c75ada6bce5ea6942dd6d9e2ed8f0a

Powered by Google App Engine
This is Rietveld 408576698