Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 1632933002: linux_dumper_unittest_helper: move to a check-only binary (Closed)

Created:
4 years, 11 months ago by vapier
Modified:
4 years, 10 months ago
Reviewers:
ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

linux_dumper_unittest_helper: move to a check-only binary There's no need for this binary outside of local tests, so stop building/installing it by default. BUG=chromium:579384 TEST=`make check` passe R=ivanpe@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/108d705fdffe3129a9bd2eedd1b24e38d878362a

Patch Set 1 #

Patch Set 2 : rebase/regen Makefile.in #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M Makefile.am View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Makefile.in View 1 2 8 chunks +29 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vapier
4 years, 11 months ago (2016-01-25 23:47:40 UTC) #2
vapier
ping ...
4 years, 10 months ago (2016-02-17 04:37:27 UTC) #3
ivanpe
On 2016/02/17 04:37:27, vapier wrote: > ping ... LGTM
4 years, 10 months ago (2016-02-17 05:46:41 UTC) #4
vapier
4 years, 10 months ago (2016-02-17 05:48:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
108d705fdffe3129a9bd2eedd1b24e38d878362a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698