Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 1632913004: Add more debugging CHECKS to diagnose an Android renderer crash. (Closed)

Created:
4 years, 11 months ago by Alexei Svitkine (slow)
Modified:
4 years, 10 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more debugging CHECKS to diagnose an Android renderer crash. Suspicion is that CreateTrialsFromSeed() is being called more than once, so add some CHECKs that will help diagnose it. If it's not being called twice but the same field trial is being registered twice, this can also cause the same issue - so catch that too. BUG=359406 Committed: https://crrev.com/7aa1af9d657f11a11c7c31bb636b0235df096e68 Cr-Commit-Position: refs/heads/master@{#372252}

Patch Set 1 #

Patch Set 2 : Update tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M base/metrics/field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/service/variations_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/service/variations_service_unittest.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Alexei Svitkine (slow)
4 years, 11 months ago (2016-01-26 19:44:15 UTC) #2
rkaplow
lgtm
4 years, 11 months ago (2016-01-27 15:56:36 UTC) #3
Alexei Svitkine (slow)
Looks like some of our unit tests hit these CHECKs. Will investigate later this week.
4 years, 11 months ago (2016-01-27 16:01:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632913004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632913004/20001
4 years, 10 months ago (2016-01-29 01:17:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 02:05:52 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 02:06:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7aa1af9d657f11a11c7c31bb636b0235df096e68
Cr-Commit-Position: refs/heads/master@{#372252}

Powered by Google App Engine
This is Rietveld 408576698