src/arm/simulator-arm.cc - Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/simulator-arm.cc

Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: mips ports Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/simulator-arm.cc

diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc

index 06c1bb9724e23ded9b413e6ff11b45b0b1d12ad4..563912bf6fa14e5c0d1dfb06fa033c097f288023 100644

--- a/src/arm/simulator-arm.cc

+++ b/src/arm/simulator-arm.cc

@@ -392,7 +392,8 @@ void ArmDebugger::Debug() {

HeapObject* obj = reinterpret_cast<HeapObject*>(*cur);

int value = *cur;

Heap* current_heap = sim_->isolate_->heap();

- if (((value & 1) == 0) || current_heap->Contains(obj)) {

+ if (((value & 1) == 0) ||

+ current_heap->ContainsSlow(obj->address())) {

PrintF(" (");

if ((value & 1) == 0) {

PrintF("smi %d", value / 2);

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm64/macro-assembler-arm64.h » ('j') | no next file with comments »