src/frames.cc - Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index 2c03e9dab07659d0616b7f0046f0e7354ca93773..e861613bc3031c95312f1d416a528f8de56dfb87 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -1519,7 +1519,7 @@ Code* InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(

Address inner_pointer) {

Heap* heap = isolate_->heap();

if (!heap->code_space()->Contains(inner_pointer) &&

- !heap->lo_space()->Contains(inner_pointer)) {

Michael Lippautz 2016/02/08 18:00:39 This was already a slow version. The name now refl

+ !heap->lo_space()->ContainsSlow(inner_pointer)) {

return nullptr;

}

« no previous file with comments | « src/assembler.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »