[heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

src/heap/slots-buffer.cc

Index: src/heap/slots-buffer.cc
diff --git a/src/heap/slots-buffer.cc b/src/heap/slots-buffer.cc
index 3f145e6e2e809b82ba286a4c99e3e78e32584c37..b7956fb3fe12b1a87cc304173073314409921999 100644
--- a/src/heap/slots-buffer.cc
+++ b/src/heap/slots-buffer.cc
@@ -56,7 +56,8 @@ void SlotsBuffer::RemoveInvalidSlots(Heap* heap, SlotsBuffer* buffer) {
         // - point to a heap object in new space
         // - are not within a live heap object on a valid pointer slot
         // - point to a heap object not on an evacuation candidate
-        if (!object->IsHeapObject() || heap->InNewSpace(object) ||
+        if (!object->IsHeapObject() ||
+            heap->InNewSpaceSlow(reinterpret_cast<Address>(object)) ||

[Michael Lippautz, 2016/02/05 12:44:40]

Since we only do the check for the live object later (line below), we need to
use the slow version here. (Slot could be in dead memory.)

(Might be gone anyways with a new slots buffer.)

             !heap->mark_compact_collector()->IsSlotInLiveObject(
                 reinterpret_cast<Address>(slot)) ||
             !Page::FromAddress(reinterpret_cast<Address>(object))