[heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

src/arm/simulator-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 #include <stdlib.h>
 #include <cmath>
 
 #if V8_TARGET_ARCH_ARM
 
@@ skipping 374 matching lines @@
           }
         }
         end = cur + words;
 
         while (cur < end) {
           PrintF("  0x%08x:  0x%08x %10d",
                  reinterpret_cast<intptr_t>(cur), *cur, *cur);
           HeapObject* obj = reinterpret_cast<HeapObject*>(*cur);
           int value = *cur;
           Heap* current_heap = sim_->isolate_->heap();
-          if (((value & 1) == 0) || current_heap->Contains(obj)) {
+          if (((value & 1) == 0) ||
+              current_heap->ContainsSlow(obj->address())) {

[Hannes Payer (out of office), 2016/02/09 14:40:22]

Why ContainsSlow here? This is not a verifier method.

[Michael Lippautz, 2016/02/09 14:50:28]

As discussed offline: There's a reinterpret_cast above (line: 392) and we are
iterating over raw memory, which could contain anything.

             PrintF(" (");
             if ((value & 1) == 0) {
               PrintF("smi %d", value / 2);
             } else {
               obj->ShortPrint();
             }
             PrintF(")");
           }
           PrintF("\n");
           cur++;
@@ skipping 3808 matching lines @@
   set_register(sp, current_sp + sizeof(uintptr_t));
   return address;
 }
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // USE_SIMULATOR
 
 #endif  // V8_TARGET_ARCH_ARM