[heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

src/arm/macro-assembler-arm.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ARM_MACRO_ASSEMBLER_ARM_H_
 #define V8_ARM_MACRO_ASSEMBLER_ARM_H_
 
 #include "src/assembler.h"
 #include "src/bailout-reason.h"
 #include "src/frames.h"
@@ skipping 201 matching lines @@
   void CheckPageFlag(Register object,
                      Register scratch,
                      int mask,
                      Condition cc,
                      Label* condition_met);
 
   // Check if object is in new space.  Jumps if the object is not in new space.
   // The register scratch can be object itself, but scratch will be clobbered.
   void JumpIfNotInNewSpace(Register object,
                            Register scratch,
                            Label* branch) {

[Hannes Payer (out of office), 2016/02/08 16:05:40]

I think this one should be ne and the one below eq.

[Michael Lippautz, 2016/02/08 18:00:38]

I don't think so. I think that the code is confusing though...

The code does:
  mask = IN_FROM_SPACE | IN_TO_SPACE
  TST flags, mask => does an AND, and sets Z(ero) flag according.
  Beq => jumps on Z set, which is when neither IN_FROM_SPACE or IN_TO_SPACE is
set

[Hannes Payer (out of office), 2016/02/08 21:33:51]

Acknowledged.

-    InNewSpace(object, scratch, ne, branch);
+    InNewSpace(object, scratch, eq, branch);
   }
 
   // Check if object is in new space.  Jumps if the object is in new space.
   // The register scratch can be object itself, but it will be clobbered.
   void JumpIfInNewSpace(Register object,
                         Register scratch,
                         Label* branch) {
-    InNewSpace(object, scratch, eq, branch);
+    InNewSpace(object, scratch, ne, branch);
   }
 
   // Check if an object has a given incremental marking color.
   void HasColor(Register object,
                 Register scratch0,
                 Register scratch1,
                 Label* has_color,
                 int first_bit,
                 int second_bit);
 
@@ skipping 1302 matching lines @@
 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
 #else
 #define ACCESS_MASM(masm) masm->
 #endif
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_ARM_MACRO_ASSEMBLER_ARM_H_