Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | src/heap/heap.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM_MACRO_ASSEMBLER_ARM_H_ 5 #ifndef V8_ARM_MACRO_ASSEMBLER_ARM_H_
6 #define V8_ARM_MACRO_ASSEMBLER_ARM_H_ 6 #define V8_ARM_MACRO_ASSEMBLER_ARM_H_
7 7
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/bailout-reason.h" 9 #include "src/bailout-reason.h"
10 #include "src/frames.h" 10 #include "src/frames.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 void CheckPageFlag(Register object, 212 void CheckPageFlag(Register object,
213 Register scratch, 213 Register scratch,
214 int mask, 214 int mask,
215 Condition cc, 215 Condition cc,
216 Label* condition_met); 216 Label* condition_met);
217 217
218 // Check if object is in new space. Jumps if the object is not in new space. 218 // Check if object is in new space. Jumps if the object is not in new space.
219 // The register scratch can be object itself, but scratch will be clobbered. 219 // The register scratch can be object itself, but scratch will be clobbered.
220 void JumpIfNotInNewSpace(Register object, 220 void JumpIfNotInNewSpace(Register object,
221 Register scratch, 221 Register scratch,
222 Label* branch) { 222 Label* branch) {
Hannes Payer (out of office) 2016/02/08 16:05:40 I think this one should be ne and the one below eq
Michael Lippautz 2016/02/08 18:00:38 I don't think so. I think that the code is confusi
Hannes Payer (out of office) 2016/02/08 21:33:51 Acknowledged.
223 InNewSpace(object, scratch, ne, branch); 223 InNewSpace(object, scratch, eq, branch);
224 } 224 }
225 225
226 // Check if object is in new space. Jumps if the object is in new space. 226 // Check if object is in new space. Jumps if the object is in new space.
227 // The register scratch can be object itself, but it will be clobbered. 227 // The register scratch can be object itself, but it will be clobbered.
228 void JumpIfInNewSpace(Register object, 228 void JumpIfInNewSpace(Register object,
229 Register scratch, 229 Register scratch,
230 Label* branch) { 230 Label* branch) {
231 InNewSpace(object, scratch, eq, branch); 231 InNewSpace(object, scratch, ne, branch);
232 } 232 }
233 233
234 // Check if an object has a given incremental marking color. 234 // Check if an object has a given incremental marking color.
235 void HasColor(Register object, 235 void HasColor(Register object,
236 Register scratch0, 236 Register scratch0,
237 Register scratch1, 237 Register scratch1,
238 Label* has_color, 238 Label* has_color,
239 int first_bit, 239 int first_bit,
240 int second_bit); 240 int second_bit);
241 241
(...skipping 1302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1544 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1545 #else 1545 #else
1546 #define ACCESS_MASM(masm) masm-> 1546 #define ACCESS_MASM(masm) masm->
1547 #endif 1547 #endif
1548 1548
1549 1549
1550 } // namespace internal 1550 } // namespace internal
1551 } // namespace v8 1551 } // namespace v8
1552 1552
1553 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1553 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | src/heap/heap.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698