Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1632803003: [turbofan] InstructionBlock::PrintBlock (Closed)

Created:
4 years, 11 months ago by Mircea Trofin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] InstructionBlock::PrintBlock Debugging helper. Centralized the logic for printing blocks from InstructionSequence. A clean(-er) design would be to define an operator<< on a PrintableInstructionBlock. However, we've discussed moving off those operators, so it seemed unnecessary to complicate the change. BUG= Committed: https://crrev.com/e3edb12fc945ebd7c3928d49687c133e8b0c0a04 Cr-Commit-Position: refs/heads/master@{#33505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -47 lines) Patch
M src/compiler/instruction.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +57 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
4 years, 11 months ago (2016-01-26 03:03:51 UTC) #3
Jarin
lgtm
4 years, 11 months ago (2016-01-26 06:13:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632803003/1
4 years, 11 months ago (2016-01-26 06:40:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 07:00:17 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 07:00:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3edb12fc945ebd7c3928d49687c133e8b0c0a04
Cr-Commit-Position: refs/heads/master@{#33505}

Powered by Google App Engine
This is Rietveld 408576698